Define a simpler row-major entity encoding for saves #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralith
force-pushed
the
simplify-saved-entities
branch
3 times, most recently
from
20b4474 to
34a97f9
Compare
patowen
approved these changes
Jan 10, 2024
Nodes are unlikely to ever have enough entities in them for column-major representation to be worth the trouble to implement. As a bonus, this representation should be compatible with postcard. We can easily switch this up again in the future if needed thanks to protobuf schema evolution.
Ralith
force-pushed
the
simplify-saved-entities
branch
from
34a97f9 to
866b3e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nodes are unlikely to ever have enough entities in them for column-major representation to be worth the trouble to implement. As a bonus, this representation should be compatible with postcard.
We can easily switch this up again in the future if needed thanks to protobuf schema evolution.